Change IPv6DualStack feature version check #1266
Conversation
|
/test e2e-metal-ipi-ovn-dualstack |
|
/test e2e-metal-ipi-ovn-ipv6 |
| find assets/generated -name '*.yaml' -exec cp -f {} ${assets_dir}/openshift \; | ||
|
|
||
| if [[ "${IP_STACK}" == "v4v6" && "$OPENSHIFT_VERSION" =~ 4.[67] ]]; then | ||
| if [[ "${IP_STACK}" == "v4v6" && "$(openshift_version $OCP_DIR)" =~ 4.[67] ]]; then |
There was a problem hiding this comment.
Ah good catch, I wonder if we can either remove OPENSHIFT_VERSION, or make it local to the places it's really needed (only the oc download IIRC, everywhere else we should use the release-derived version since #1146)
There was a problem hiding this comment.
Thanks @hardys
I'll check the other places as well, if it does not need dramatic changes, I can add it to this PR.
There was a problem hiding this comment.
I removed OPENSHIFT_VERSION usage only
Line 93 in 82293c9
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hardys The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/test e2e-metal-ipi-ovn-dualstack |
|
/test e2e-metal-ipi-ovn-ipv6 |
|
/test e2e-metal-ipi-ovn-dualstack |
|
/lgtm |
|
/test e2e-metal-ipi-ovn-ipv6 |
|
/test e2e-metal-ipi |
|
@ardaguclu: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/test e2e-metal-ipi-ovn-ipv6 |
5 participants
This PR changes version extraction method for IPv6DualStack feature apply. In CI,
OPENSHIFT_VERSIONis always unset and for 4.6 and 4.7 versions, this condition is always false. Thereby, dualstack jobs are failing in these versions.